Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(browse-ci): add unit tests #1130

Merged
merged 1 commit into from
Jan 30, 2024
Merged

test(browse-ci): add unit tests #1130

merged 1 commit into from
Jan 30, 2024

Conversation

vanpipy
Copy link
Collaborator

@vanpipy vanpipy commented Jan 26, 2024

Close #1128

@spacewander
Copy link
Collaborator

Sorry for not handling it on time! I am too busy this week, just get some sparse time at the weekend.

@spacewander
Copy link
Collaborator

After this PR is merged, @vanpipy you can refactor it via some metaprogramming (maybe using a function builder or something else). This will make the code simpler.

@spacewander spacewander merged commit 5f19424 into tj:main Jan 30, 2024
15 checks passed
@chenrui333 chenrui333 mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyperupcall hyperupcall hyperupcall approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test(git-browse-ci): add unit tests
3 participants
@vanpipy @spacewander @hyperupcall