Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enqueue reconciliation when Machine connection information changes #23

Open
chrisdoherty4 opened this issue Jun 23, 2022 · 0 comments
Open

Enqueue reconciliation when Machine connection information changes #23

chrisdoherty4 opened this issue Jun 23, 2022 · 0 comments
Labels
kind/feature New feature or request

Comments

@chrisdoherty4
Copy link
Member

The Machine type specifies the Contactable condition that proves useful for clients in understanding connection state.

If the secret information for connecting to the endpoint changes we don't currently queue a reconciliation and retry the connection. This results in a misrepresentation of the contactable condition.

We can watch for changes in the secret object and requeue when its updated.
@chrisdoherty4 chrisdoherty4 added the kind/bug Categorizes issue or PR as related to a bug. label Jun 23, 2022
@chrisdoherty4 chrisdoherty4 added this to the 0.1.0 milestone Jun 23, 2022
@chrisdoherty4 chrisdoherty4 added kind/feature New feature or request and removed kind/bug Categorizes issue or PR as related to a bug. labels Jul 4, 2022
@chrisdoherty4 chrisdoherty4 modified the milestones: 0.1, 0.2 Jul 4, 2022
@chrisdoherty4 chrisdoherty4 modified the milestones: 0.2, 0.3 Aug 31, 2022
@chrisdoherty4 chrisdoherty4 removed this from the v0.3 milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisdoherty4