Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource Validation #4

Open
chrisdoherty4 opened this issue Dec 24, 2022 · 2 comments
Open

Resource Validation #4

chrisdoherty4 opened this issue Dec 24, 2022 · 2 comments
Assignees
@chrisdoherty4
Labels
status/accepted The scope and kind of work is agreed and the item accepted to the backlog theme/feature New functionality in Tinkerbell

Comments

@chrisdoherty4
Copy link
Member

chrisdoherty4 commented Dec 24, 2022 •
edited
Loading

Tinkerbells primary backend is Kubernetes. This means it acts as the data source for Hardware, Workflows and Templates. When these objects are submitted to the cluster they do not undergo any validation. This theme of work is to address general issues encountered by users when submitting data to Tinkerbell.

Project (Combined with CRD Refactor)
https://github.com/orgs/tinkerbell/projects/26

Related
tinkerbell/tink#532
@chrisdoherty4 chrisdoherty4 converted this from a draft issue Dec 24, 2022
@chrisdoherty4
Copy link
Member Author

Initial suggestion is to implement webhooks. Webhooks will give us an opportunity to identify duplicate MAC addresses and IP configurations as well as default any state the user shouldn't need to care about on first submission of Hardware.

https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/

@chrisdoherty4 chrisdoherty4 changed the title Validation Resource Validation Dec 24, 2022
@chrisdoherty4 chrisdoherty4 added theme/feature New functionality in Tinkerbell status/discussion The scope and kind of work is still in discussion labels Dec 27, 2022
@chrisdoherty4 chrisdoherty4 moved this from Discussion to Accepted in Tinkerbell Roadmap Jan 17, 2023
@chrisdoherty4 chrisdoherty4 self-assigned this Jan 17, 2023
@chrisdoherty4
Copy link
Member Author

We're going to couple this with #14 but will maintain this ticket for independent tracking.

@chrisdoherty4 chrisdoherty4 added status/accepted The scope and kind of work is agreed and the item accepted to the backlog and removed status/discussion The scope and kind of work is still in discussion labels Jan 17, 2023
@chrisdoherty4 chrisdoherty4 moved this from Accepted to In progress in Tinkerbell Roadmap Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisdoherty4 chrisdoherty4

Labels
status/accepted The scope and kind of work is agreed and the item accepted to the backlog theme/feature New functionality in Tinkerbell
Projects
Tinkerbell Roadmap
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisdoherty4