From 9fa6df77b86338a19c4fbead7307576facdc128a Mon Sep 17 00:00:00 2001 From: juerg Date: Tue, 2 Apr 2024 04:46:12 -0700 Subject: [PATCH] Remove EcdsaProtoTest.java. This test is not really needed. That this proto works is tested implicitly by other tests. PiperOrigin-RevId: 621133610 --- .../java/com/google/crypto/tink/BUILD.bazel | 10 ----- .../google/crypto/tink/EcdsaProtoTest.java | 39 ------------------- 2 files changed, 49 deletions(-) delete mode 100644 java_src/src/test/java/com/google/crypto/tink/EcdsaProtoTest.java diff --git a/java_src/src/test/java/com/google/crypto/tink/BUILD.bazel b/java_src/src/test/java/com/google/crypto/tink/BUILD.bazel index 2eca2f8cf1..a99579fbea 100644 --- a/java_src/src/test/java/com/google/crypto/tink/BUILD.bazel +++ b/java_src/src/test/java/com/google/crypto/tink/BUILD.bazel @@ -142,16 +142,6 @@ java_test( ], ) -java_test( - name = "EcdsaProtoTest", - size = "small", - srcs = ["EcdsaProtoTest.java"], - deps = [ - "//proto:ecdsa_java_proto", - "@maven//:junit_junit", - ], -) - java_test( name = "CryptoFormatTest", size = "small", diff --git a/java_src/src/test/java/com/google/crypto/tink/EcdsaProtoTest.java b/java_src/src/test/java/com/google/crypto/tink/EcdsaProtoTest.java deleted file mode 100644 index c9acd7cf42..0000000000 --- a/java_src/src/test/java/com/google/crypto/tink/EcdsaProtoTest.java +++ /dev/null @@ -1,39 +0,0 @@ -// Copyright 2017 Google Inc. -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. -// -//////////////////////////////////////////////////////////////////////////////// - -package com.google.crypto.tink; - -import static org.junit.Assert.assertEquals; - -import com.google.crypto.tink.proto.EcdsaPublicKey; -import org.junit.Test; -import org.junit.runner.RunWith; -import org.junit.runners.JUnit4; - -/** - * A simple integration test to see whether Ecdsa protobuf is built correctly. - * - *

TODO(quannguyen): Add extensive tests. - */ -@RunWith(JUnit4.class) -public class EcdsaProtoTest { - - @Test - public void testKeysetBasic() throws Exception { - EcdsaPublicKey publicKey = EcdsaPublicKey.newBuilder().setVersion(1).build(); - assertEquals(1, publicKey.getVersion()); - } -}