Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Custom Chains to All Builders #23

Open
dowlandaiello opened this issue Aug 20, 2024 · 0 comments
Open

Add Support for Custom Chains to All Builders #23

dowlandaiello opened this issue Aug 20, 2024 · 0 comments
Assignees
@dowlandaiello
Labels
enhancement New feature or request

Comments

@dowlandaiello
Copy link
Contributor

dowlandaiello commented Aug 20, 2024 •
edited
Loading

All builders that invoke .get_chain should support overriding Neutron to some custom chain. This will involve removing all calls to .get_contract, and replacing them with .get_contract_on, which takes the chain to get the contract code ID from as a parameter.

Related: #11 . Migrating all queries, like get_contract to the TestContextQuery allows more gently deprecating .get_contract by allowing users to not specify the src_chain, defaulting to Neutron.

Recommendations

  • Deprecate .get_contract (move to TestContextQuery if possible)
  • Move .get_contract to a TestContextQuery
  • Make all builders that deal with a chain expose and respect .with_chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dowlandaiello dowlandaiello

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dowlandaiello