Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ComboBox] ListBox shouldn't have a close button #64

Open
navin-moorthy opened this issue May 15, 2020 · 3 comments
Open

[ComboBox] ListBox shouldn't have a close button #64

navin-moorthy opened this issue May 15, 2020 · 3 comments
Assignees
Labels
Status: Assigned ➡ This issue has been assigned to a team member Topic: Design and UX ✍️ Type: Bug 🐛 Something isn't working

Comments

@navin-moorthy
Copy link
Collaborator

@prasanna1211 thinks list box shouldn't have close button.

image

Originally posted at issue

@navin-moorthy navin-moorthy added Type: Bug 🐛 Something isn't working Topic: UX 🤳 labels May 15, 2020
@navin-moorthy navin-moorthy self-assigned this May 15, 2020
@navin-moorthy navin-moorthy added the Status: Assigned ➡ This issue has been assigned to a team member label May 15, 2020
@navin-moorthy
Copy link
Collaborator Author

As per the standard there is no close button for combo-box, it's part of UX I guess.
May we can make it hide with props if they don't want or by default it will be hidden and can have it with props

https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html

@navin-moorthy
Copy link
Collaborator Author

@prasanna1211 and @sandeepprabhakaran Do we need close button on the listbox?
In my opinion, we can have it, or make it as prop to show or hide.

@prasanna1211
Copy link
Contributor

With props, yes I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Assigned ➡ This issue has been assigned to a team member Topic: Design and UX ✍️ Type: Bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants