Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Settings Page is blank. #225

Closed
Redster1 opened this issue Sep 4, 2024 · 5 comments
Closed

Plugin Settings Page is blank. #225

Redster1 opened this issue Sep 4, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@Redster1
Copy link

Redster1 commented Sep 4, 2024

The settings page for the plugin is blank except for the sponsor button.

image

When I open the console, this error message appears and seems relevant.

VM343 plugin:obsidia…ble-reference:12979 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'isFeatureEnabled')
    at BibleReferenceSettingTab.setUpVersionSettingsAndVersionOptions (VM343 plugin:obsidia…-reference:12979:50)
    at BibleReferenceSettingTab.display (VM343 plugin:obsidia…-reference:12848:10)

That seems related to this function here:

  setUpVersionSettingsAndVersionOptions() {
    let allAvailableVersionOptions = allBibleVersionsWithLanguageNameAlphabetically;
    const disableBibleAPI = FlagService.instance.isFeatureEnabled("disable-bible-api");  //  <-- This line specifically as the .isFeatureEnabled is flagged as having an error.
    if (disableBibleAPI) {
      allAvailableVersionOptions = allAvailableVersionOptions.filter((v) => {
        return v.apiSource.name !== BibleAPISourceCollection.bibleApi.name;
      });
    }
  • Device: Lenovo Thinkpad T480
  • OS: Windows 10
  • Obsidian Version : v1 .7.1 (Installer version: V1 .5.12)
  • Plugin Version: v3.1.1

image

I probably wouldn't have worried about reporting this, but it switched Bible versions on me and I can't switch translations.

  • I'm on the default Obsidian Theme and have no other plugins installed.
  • Tried uninstalling and reinstalling the plugin.
  • Not sure when this started.

Happy to poke around and try to help in any way I can or provide more info.

Thanks so much for this awesome plugin. I love it. It's been super helpful as I've been working on a research project on the conscience.

@Redster1 Redster1 added the bug Something isn't working label Sep 4, 2024
@tim-hub
Copy link
Owner

tim-hub commented Sep 4, 2024

Thanks, I can see it in one of my computers as well, let me fix it.

@tim-hub
Copy link
Owner

tim-hub commented Sep 4, 2024

It is fixed in 3.1.2, can you have a try?

https://github.com/tim-hub/obsidian-bible-reference/releases/tag/3.1.2

@tim-hub
Copy link
Owner

tim-hub commented Sep 4, 2024

@all-contributors add @Redster1 for bug

Copy link
Contributor

@tim-hub

I've put up a pull request to add @Redster1! 🎉

@Redster1
Copy link
Author

Redster1 commented Sep 4, 2024

It's fixed! 🎉
Thank you so much!

@Redster1 Redster1 closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants