Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/http: implement the marshaler interfaces for Rule/RuleOp #7462

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7300.

What is changed and how does it work?

Implement the marshaler interfaces for `Rule` and `RuleOP` to make sure we could set/get the correct start/end key.

Ref https://github.com/pingcap/tidb/blob/46d4231c8b0ade353b98572e7c2a015bddf940f4/pkg/ddl/placement/rule.go#L76-L91.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label Nov 28, 2023
@JmPotato JmPotato requested review from rleungx and HuSharp November 28, 2023 08:14
Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2023
@JmPotato JmPotato force-pushed the rule_key_hex branch 3 times, most recently from 2205946 to 345491d Compare November 28, 2023 12:32
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2023
@JmPotato
Copy link
Member Author

/test build

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #7462 (259b48d) into master (beedacb) will decrease coverage by 0.06%.
The diff coverage is 61.53%.

❗ Current head 259b48d differs from pull request most recent head a98d738. Consider uploading reports for the commit a98d738 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7462      +/-   ##
==========================================
- Coverage   74.31%   74.25%   -0.06%     
==========================================
  Files         451      452       +1     
  Lines       49757    49899     +142     
==========================================
+ Hits        36977    37054      +77     
- Misses       9456     9506      +50     
- Partials     3324     3339      +15     
Flag Coverage Δ
unittests 74.25% <61.53%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@JmPotato JmPotato requested a review from CabinfeverB November 29, 2023 06:49
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 29, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2023
client/http/client.go Show resolved Hide resolved
client/http/client.go Show resolved Hide resolved
client/http/codec.go Outdated Show resolved Hide resolved
@JmPotato JmPotato requested a review from HuSharp November 30, 2023 07:57
Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2023
@JmPotato
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: a98d738

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2023
@JmPotato JmPotato changed the title client/http: implement the marshaler interfaces for Rule/RuleOP client/http: implement the marshaler interfaces for Rule/RuleOp Nov 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit 862eee1 into tikv:master Nov 30, 2023
22 checks passed
@JmPotato JmPotato deleted the rule_key_hex branch November 30, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/client Client logic. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants