-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client/http: implement the marshaler interfaces for Rule/RuleOp #7462
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
2205946
to
345491d
Compare
/test build |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7462 +/- ##
==========================================
- Coverage 74.31% 74.25% -0.06%
==========================================
Files 451 452 +1
Lines 49757 49899 +142
==========================================
+ Hits 36977 37054 +77
- Misses 9456 9506 +50
- Partials 3324 3339 +15
Flags with carried forward coverage won't be shown. Click here to find out more. |
345491d
to
b9548e2
Compare
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
259b48d
to
a98d738
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: a98d738
|
What problem does this PR solve?
Issue Number: ref #7300.
What is changed and how does it work?
Check List
Tests
Release note