Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Add tests to discount functions #86

Open
ricardobrg opened this issue Aug 17, 2023 · 0 comments
Open

Add tests to discount functions #86

ricardobrg opened this issue Aug 17, 2023 · 0 comments
Labels
testing Related to testing.
Milestone
1.0 version

Comments

@ricardobrg
Copy link
Collaborator

ricardobrg commented Aug 17, 2023 •
edited
Loading

As a maintainer
I need to ensure that the code has proper automated tests
so that we prevent breaking changes and unknown bugs.

What it is now

For the discount functions, we have all the jsons to manually test it, but no automated tests configured

What it should be

The automated tests are configured and run in all PRs.

Acceptance criteria

  • Unit tests for the functions are configured
  • CI tests are configured in Github actions
@ricardobrg ricardobrg converted this from a draft issue Aug 17, 2023
@ricardobrg ricardobrg self-assigned this Aug 17, 2023
@ricardobrg ricardobrg removed this from Roadmap Aug 31, 2023
@ricardobrg ricardobrg added this to the 1.0 version milestone Sep 5, 2023
@ricardobrg ricardobrg assigned MiroBenicio and unassigned ricardobrg Sep 11, 2023
@ricardobrg ricardobrg added the testing Related to testing. label Sep 15, 2023
@timoguin timoguin mentioned this issue Sep 19, 2023
Closed
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testing Related to testing.
Projects
None yet
Milestone
1.0 version
Development

No branches or pull requests
2 participants
@ricardobrg @MiroBenicio