Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd Threshold? #44

Open
slsnow opened this issue Feb 9, 2023 · 7 comments · May be fixed by #60
Open

2nd Threshold? #44

slsnow opened this issue Feb 9, 2023 · 7 comments · May be fixed by #60
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@slsnow
Copy link

slsnow commented Feb 9, 2023

It might be nice if there were an intermediate threshold as well. For example, I have mine set at 25% fan speed, which is fine most of the time. However, occasionally when the load increases, it will jump to the BIOS setting, and be running at like 93% for a bit until it cools down.

I'd prefer to have at least one more threshold, as an option. When it hits that 2nd threshold, perhaps I'd set the fan to go up 45% or 50% instead of the BIOS settings. Then, if it hits my current threshold, it would kick over to the BIOS like normal.

Hopefully that makes sense, and I know that if you could have 2, then people could request 3, 4, or 5. Hopefully people wouldn't ask for that, but I think that 2 would be sufficient for me.

Either way, thanks a ton. This has been the best solution I've found.

@tigerblue77
Copy link
Owner

tigerblue77 commented Feb 10, 2023

Hey, why not but it would need some more code and I don't have much time actually. It will also need a second FAN_SPEED environment variable. By idea would be more like :

  • lowest speed :
    • user defined speed
    • default mode when < 1st threshold
  • middle speed :
    • user defined speed, must be > lowest speed
    • mode when > 1st threshold and < lm-sensors high CPU temperature
  • high speed (security mode) :
    • Dell default fan control profile
    • mode when > lm-sensors critical CPU temperature

So that no 2nd threshold would be needed and it would (should) fit any CPU configuration.

@slsnow
Copy link
Author

slsnow commented Feb 10, 2023

Yeah, that sounds perfect.

@macj72x
Copy link

macj72x commented Feb 24, 2023

I would love to see this as well. If possible adding a few thresholds and making this more variable would be great.

@ThatCoffeeGuy
Copy link

I would love to see this. if I have the time, I will try to put it together and commit for review.

@tigerblue77 tigerblue77 added enhancement New feature or request good first issue Good for newcomers labels Apr 4, 2023
@zepanv
Copy link

zepanv commented May 21, 2023

Having another step would be nice or even a curve that could be calculated based on the FAN_SPEED variable, it would still require a second variable but it could work something like:
FAN_SPEED = 10
CPU_TEMPERATURE_THRESHOLD = 50 (default to bios)
SCALING_CPU_TEMPERATURE = 45

So it will run at 10% until it hits 45 degrees, then it will increment fan speed to try to bring it down before it hits the threshold of 50 and goes full blast.
Could even increment it by FAN_SPEED so at 45 it will go to 20, then next CHECK_INTERVAL if it is still above 45 it would keep adding FAN_SPEED until it either went under 45 or hit 50 and defaulted as normal.

norahqueen pushed a commit to norahqueen/Dell_iDRAC_fan_controller_Docker that referenced this issue Jun 24, 2023
wrote this before seeing issue tigerblue77#44 and tigerblue77's comment on
implementation
@norahqueen
Copy link

I had a go at creating a pull request for this.

@7Adrian 7Adrian linked a pull request Jul 23, 2023 that will close this issue
@7Adrian
Copy link

7Adrian commented Jul 23, 2023

Hi, I created pull request for that upgrade. I used line interpolation in my solution. You can check it in #60.

Quick example how my solution work:

  • ENABLE_LINE_INTERPOLATION = true
  • FAN_SPEED = 10
  • HIGH_FAN_SPEED = 50
  • CPU_TEMPERATURE_FOR_START_LINE_INTERPOLATION = 30
  • CPU_TEMPERATURE_THRESHOLD = 70
CPU Temperature Fan Speed
15 °C 10 %
30 °C 10 %
35 °C 15 %
50 °C 30 %
69 °C 49 %
70 °C Dell fan control

@tigerblue77 tigerblue77 linked a pull request Jan 20, 2024 that will close this issue
@tigerblue77 tigerblue77 self-assigned this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
7 participants