Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHA #322

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Update GHA #322

merged 6 commits into from
Jun 10, 2024

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Jun 10, 2024

To separate GHA setup failures from failures due to new survival package in #321

@hfrick
Copy link
Member Author

hfrick commented Jun 10, 2024

Now all failures are due to the new version of survival.

The approach here is to not install selected packages in Suggests along with skipping tests that need those packages.

This is nicer than what we did previously, where we skipped an entire run on, e.g., oldrel-4. With this new approach, the tests beyond the selected ones are still running for older versions of R, and we don't need to manually re-activate GHA workflow runs when a new R version becomes available (because we can specify the absolute version in the extra-packages instead of the relative version via oldrel-X).

@hfrick hfrick merged commit 3f54ad6 into main Jun 10, 2024
8 of 12 checks passed
@hfrick hfrick deleted the gha-update branch June 10, 2024 16:11
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant