Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning 'onRequestClose' #1

Open
valeriaabo opened this issue Jun 30, 2017 · 7 comments
Open

Warning 'onRequestClose' #1

valeriaabo opened this issue Jun 30, 2017 · 7 comments
Assignees
Labels

Comments

@valeriaabo
Copy link

Im using FitModal and Im getting the error message:

Warning: Failed prop type: The prop 'onRequestClose' is marked as required in 'Modal' but value is 'undefined'.

Does anyone know how to fix it? Please! :(

@tibbus
Copy link
Owner

tibbus commented Jul 1, 2017

Hi @valeriaabo I think this is because you are on Android ? I tested it only for iOS.

I will look in to it though.

@tibbus tibbus self-assigned this Jul 1, 2017
@tibbus tibbus added the bug label Jul 1, 2017
@tibbus
Copy link
Owner

tibbus commented Jul 1, 2017

I have added a new release 1.1.1 which fixes this issue.
If you upgrade to that version it should fix the Warning.

@valeriaabo
Copy link
Author

Thanks a lot, it works but now Im getting another error with the react-native-fetch-blob, and the top bar is not hidding when the modal opens :(

@tibbus
Copy link
Owner

tibbus commented Jul 3, 2017

the react-native-fetch-blob is a package that was removed, I think it should be fixed if you remove the react-native-fit package and install it again, also run react-native link to updates the links

@valeriaabo
Copy link
Author

@tibbus
Thanks the errors are gone, just one thing, the top status bar ( where you see the battery, hour, etc ) is supposed to be shown when the modal is open? Im testing on android

@tibbus
Copy link
Owner

tibbus commented Jul 3, 2017

No, there is some code to hide it, but tested only on iOS, should also work on Android but will look into it to see what can be wrong.

@valeriaabo
Copy link
Author

OK thanks a lot! I'll be patiently waiting :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants