-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Custom] Enhancement for modules #2225
Comments
Maybe they will update it eventually now that modules.img mount detection method is public See: https://github.com/reveny/Android-Native-Root-Detector/releases/tag/v6.5.3 |
Without installing modules, it will not be detected, but as long as any module is installed, it will be detected. When KSU is detected, the phone storage space will also become 2TB(fake space). |
basically the logic is
from
basically it sees a journaled loop device due to the mount
yeah I guess sparseness can also be used as another detection point |
It is able to refer to this commit from APatch for repair. However, some method names and variables have significant differences and need to be noted. |
Describe your problem.
Is it possible to make the module function without img?
This 1tb sparse file img brings a lot of serious bugs.
When some modules are installed, the system storage space will become 2TB or bigger(I'd like to specifically note that the bug is present on other devices besides Samsung devices. known to reproduce are oppo, Xiaomi, and lineageos, all of which show 2TB of storage.). This causes the automatic cleaning of many junk cleaning apps to fail.
Using a single img file seems very rigid and greatly reduces compatibility, leading to problems with many devices and modules that don't work, especially modules that require files to be downloaded during installation or large modules.
It even causes trim to not work at all.
Even, it has become a kernelsu fingerprint, which can be used to detect kernelsu directly.
APatch has already deprecated img, I think KernelSU should follow suit.
The text was updated successfully, but these errors were encountered: