Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing the minimum-stability to stable #13

Open
alexpott opened this issue May 19, 2020 · 0 comments
Open

Consider changing the minimum-stability to stable #13

alexpott opened this issue May 19, 2020 · 0 comments

Comments

@alexpott
Copy link
Contributor

The drupal/recommended-project composer project template recently had a bug that meant running composer update resulted in get a dev core release. See https://www.drupal.org/project/drupal/issues/3135247 and composer/composer#8882

This same problem could hit the thunder project. We should consider removing the minimum-stability flag from the template.

Doing this at the moment results in:

  Problem 1
    - thunder/thunder-distribution 3.4.5 requires drupal/access_unpublished ^1.0-alpha8 -> satisfiable by drupal/access_unpublished[1.x-dev, 1.0.0-alpha8, 1.0.0-beta1, 1.0.0-beta2] but these conflict with your requirements or minimum-stability.
    - thunder/thunder-distribution 3.4.4 requires drupal/access_unpublished ^1.0-alpha8 -> satisfiable by drupal/access_unpublished[1.x-dev, 1.0.0-alpha8, 1.0.0-beta1, 1.0.0-beta2] but these conflict with your requirements or minimum-stability.
    - thunder/thunder-distribution 3.4.3 requires drupal/access_unpublished ^1.0-alpha8 -> satisfiable by drupal/access_unpublished[1.x-dev, 1.0.0-alpha8, 1.0.0-beta1, 1.0.0-beta2] but these conflict with your requirements or minimum-stability.
    - thunder/thunder-distribution 3.4.2 requires drupal/access_unpublished ^1.0-alpha8 -> satisfiable by drupal/access_unpublished[1.x-dev, 1.0.0-alpha8, 1.0.0-beta1, 1.0.0-beta2] but these conflict with your requirements or minimum-stability.
    - thunder/thunder-distribution 3.4.1 requires drupal/access_unpublished ^1.0-alpha8 -> satisfiable by drupal/access_unpublished[1.x-dev, 1.0.0-alpha8, 1.0.0-beta1, 1.0.0-beta2] but these conflict with your requirements or minimum-stability.
    - thunder/thunder-distribution 3.4.0 requires drupal/access_unpublished ^1.0-alpha8 -> satisfiable by drupal/access_unpublished[1.x-dev, 1.0.0-alpha8, 1.0.0-beta1, 1.0.0-beta2] but these conflict with your requirements or minimum-stability.
    - Installation request for thunder/thunder-distribution ~3.4 -> satisfiable by thunder/thunder-distribution[3.4.0, 3.4.1, 3.4.2, 3.4.3, 3.4.4, 3.4.5].

At the moment the thunder-distribution is relying on the top-level composer.json minimum-stability to allow installation.

We need to add stability flags for all of these modules:

drupal/access_unpublished                       1.0.0-beta2   Grants access to view unpublished content to anyone who has a unique URL and appropriate permissions.
drupal/autofill                                 1.0.0-alpha2  A field can automatically be autofilled while typing into another one
drupal/better_normalizers                       1.0.0-beta4   Improve the normalizers in core.
drupal/breakpoint_js_settings                   1.0.0-rc1     Write breakpoint information into javascript settings.
drupal/default_content                          1.0.0-alpha9  Imports default content when a module is enabled
drupal/empty_fields                             1.0.0-alpha1  Provides options for displaying empty fields.
drupal/inline_entity_form                       1.0.0-rc6     Provides a widget for inline management (creation, modification, removal) of referenced entities.
drupal/libraries                                3.0.0-alpha1  Allows version-dependent and shared usage of external libraries in Drupal.
drupal/linkit                                   5.0.0-beta10  Linkit - Enriched linking experience
drupal/liveblog                                 1.2.0-alpha14 Liveblogging module for Drupal
drupal/password_policy                          3.0.0-beta1   Sets up constraints and expiration of passwords.
drupal/responsive_preview                       1.0.0-beta1   Provides a component that previews a page in various device dimensions.
drupal/slick_media                              2.0.0-alpha3  Provides Slick carousel integration with Media entity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant