Navbar links CSS fault for mobile view (light mode)

[jollydodo]

Description

Minor issue that I just noticed (it's very subtle). When in light mode and mobile view (collapsed navbar), the search and expand icon don't get the correct color assigned. This has to do with the btn-link class which is overwritten by the offcanvas class in expanded mode, but not in mobile mode which results in added transparency that looks quite odd (in dark mode it does work as expected).

Wrong color (getdoks website):

My own website has an extra icon where it is more noticeable:

Expected (full view):

Mobile view light mode wrong color:

Correct color in normal widescreen view:

I've now fixed it with some simple custom css, but it would off course be nicer for everyone if this was fixed in the Doks repo.

Steps to reproduce

Simply resize your browser from normal view to mobile view in light mode and look for the subtle discrepancy.

Expected result

The same class as in darkmode/normal view should be assigned so that the buttons simply get the $primary color assigned.

Actual result

Wrong color + transparency is added

Environment

Tested it in my own environment, but it is also visible / reproducible on the getdoks website.

[h-enk]

Good catch!