Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering broken on dark-theme cards #1143

Open
c4lliope opened this issue Dec 12, 2023 · 1 comment
Open

Rendering broken on dark-theme cards #1143

c4lliope opened this issue Dec 12, 2023 · 1 comment

Comments

@c4lliope
Copy link

Hello - here's an example using Doks on https://www.cloudhypervisor.org/ -
you can see the .card selector has precedence for rendering a dark font color rule, regardless of the dark background theme on the page.

image

@h-enk
Copy link
Member

h-enk commented Dec 13, 2023

Add color: $body-color-dark; to assets/scss/common/_dark.scss — see also https://github.com/cloud-hypervisor/cloud-hypervisor.github.io/blob/main/assets/scss/common/_dark.scss#L379-L382 — and you're good to go

[data-dark-mode] body .card {
  background: $body-bg-dark;
  border: 1px solid $border-dark;
  color: $body-color-dark;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants