Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traceback in log despite graceful exit #905

Open
3 tasks done
madduck opened this issue Oct 13, 2023 · 0 comments
Open
3 tasks done

Traceback in log despite graceful exit #905

madduck opened this issue Oct 13, 2023 · 0 comments

Comments

@madduck
Copy link

madduck commented Oct 13, 2023

Prerequisites

  • Tried the most recent nightly build
  • Checked if your issue is already reported.
  • Answered all the questions in this template (Or provide a working crystal ball).

What happened?

If a user just closes the tab without disconnecting (which all users will do), the logs get a traceback:

2023-10-13 12:18:19 WARNING [handle_message] webserver.py : Connection gracefully closed. 1001
2023-10-13 12:18:19 WARNING [handle_message] webserver.py : Traceback (most recent call last):
  File "/srv/managesieve/build/web/script/webserver.py", line 65, in handle_message
    handler.handle_request(context, request)
  File "/srv/managesieve/build/web/script/handler/websocket.py", line 48, in handle_request
    MessagePump().run(websocket, sievesocket)
  File "/srv/managesieve/build/web/script/messagepump.py", line 26, in run
    data = server.recv()
           ^^^^^^^^^^^^^
  File "/srv/managesieve/build/web/script/websocket.py", line 134, in recv
    raise Exception("Connection gracefully closed. "+str(code)+" "+text.decode())
Exception: Connection gracefully closed. 1001

What did you expect to happen?

If it's a graceful closure, then there should be no log entry, definitely not
a traceback.

Which Version

Include information about your system, server and most important if it is about the app or webextension.

  • Web app @8a1af600e42bff2440e959a268afcab3385418a1
  • NGinX on Debian stable; Firefox 117 on Debian unstable
  • Dovecot Pigeonhole on Debian stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant