Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover Account: Improve error messages #542

Open
mohamedamer453 opened this issue Aug 23, 2023 · 3 comments
Open

Recover Account: Improve error messages #542

mohamedamer453 opened this issue Aug 23, 2023 · 3 comments
Assignees
Labels
type_bug Something isn't working
Milestone

Comments

@mohamedamer453
Copy link

Description

The error messages in the recover account page should be improved. Currently the error messages are not very user friendly and has keywords like exception and Invalid arguments before the message itself. also there's an error message that mentiones that the mnemonic is invalid while mnemonic is correct it should be Seed since the field itself is called Seed Phrase and there's no mention of mnemonic anywhere else in the app.

image

image

image

image

image

Environment

  • Android Version: 13
  • Threefold Connect version: 3.7.3 - 173
@zaelgohary
Copy link
Contributor

Work completed:

  • Refactor validateNameSeed
  • Remove 'Exception'

@atefnazmy
Copy link

@atefnazmy
Copy link

  • The "Exception" was not removed as mentioned above.
  • The empty Seed field case doesn't follow the approach.

message
recover

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants