Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: Nodes with network contract cruft don't go standby #966

Open
scottyeager opened this issue Mar 20, 2024 · 2 comments
Open

🐞 [Bug]: Nodes with network contract cruft don't go standby #966

scottyeager opened this issue Mar 20, 2024 · 2 comments
Labels
farmerbot process_wontfix This will not be worked on type_bug Something isn't working
Milestone

Comments

@scottyeager
Copy link

scottyeager commented Mar 20, 2024

What happened?

One farmer asked why their nodes were not going to standby state when using farmerbot. The two nodes in question are 176 and 597 on mainnet. The farm has one other node which is successfully going standby.

Checking these nodes, they each have 1 workload and 1 deployment but 0% CPU reserved. For example:

image

image

Looking in GraphQL, we can see these are only network contracts:

image

For whatever reasons, it's not uncommon that network contracts get left behind in the course of deleting deployments. These contracts have no function if there's not an associated VM on the node, but they are keeping the node from going standby. The only exception I could think of would be gateway nodes, which might have some network contracts for providing gateway access, but those should not be going standby anyway.

I see two possible resolutions:

  1. Base the determination of whether a node is in use on whether there is any CPU reserved
  2. Filter out the network workloads when looking at active contracts

which network/s did you face the problem on?

Main

@scottyeager scottyeager added type_bug Something isn't working farmerbot labels Mar 20, 2024
@rawdaGastan
Copy link
Collaborator

It is not allowed to power off nodes with active contracts

@scottyeager
Copy link
Author

I see. Will need to address upstream at TF Chain.

I'll leave this one open too for now.

@xmonader xmonader added the process_wontfix This will not be worked on label May 1, 2024
@xmonader xmonader added this to the later milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
farmerbot process_wontfix This will not be worked on type_bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants