Update data_texture.dart #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using DataTexture fails in web_gl_renderer.dart:6837, because image parameter is instance of LinkedHashMap and there is no "width" nor "height" getter. Creating and passing instance of DataImage class instead of {"data":data,"width":width,"height":height} solves the problem.
Other problem is that all optional parameters are automatically passed as null and WebGL prints out warning about illegal texture parameters value.
|
Can you reformat this please according to tool/dartfmt.sh, and rebase on the latest master? Looks good to me otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using DataTexture fails in web_gl_renderer.dart:6837, because image parameter is instance of LinkedHashMap and there is no "width" nor "height" getter. Creating and passing instance of DataImage class instead of {"data":data,"width":width,"height":height} solves the problem.
Other problem is that all optional parameters are automatically passed as null and WebGL prints out warning about illegal texture parameters value.