Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure out an easier way to add new/alternative versions (aka better support for trials) #114

Open
DankRank opened this issue Aug 21, 2023 · 0 comments

Comments

@DankRank
Copy link
Member

There are many instances where we don't support the trial versions:

  • th19 trial ANM have the extra fields in sprite_t, but not the PNG/JPEG compression as used in the full version
  • th09 trial Plus DAT has to be extracted with -x8 because of different crypt_parms
  • at least one trial (forgot which one) has differences in ECL signatures

It'd be nice to be able to add these things without having to add a new flag or having to come up with another version integer and updating all the NEWHU: places. I'm thinking each version should have a struct containing all the necessary info for a given program (stuff like th{ecl,msg,dat}_module_t, format lists, crypt_parms, flags specifying minor changes in the format, etc), and the version integer (or string) would be mapped to one of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant