Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chap. 25 Introduce Parameter Object #189

Open
hansondr opened this issue Dec 5, 2014 · 2 comments
Open

Chap. 25 Introduce Parameter Object #189

hansondr opened this issue Dec 5, 2014 · 2 comments

Comments

@hansondr
Copy link

hansondr commented Dec 5, 2014

This chapter centers around creating a simple parameter object recipient to hold on to first_name, last_name and email but doesn't actually show the implementation for this parameter object. I found this strange given that the other chapters I've read so far seem to explicitly include all the pieces for implementing the particular refactoring. Not a big deal as I imagine the class is just something like:

class Recipient
  attr_reader :first_name, :last_name, :email
  def initialize(first_name, last_name, email)
    @first_name = first_name
    @last_name = last_name
    @email = email
  end
end

Would adding the simple implementation similar to the above to the chapter add or distract from the chapter? I'm not sure if this was already internally discussed but figured I'd share my thoughts.

@jferris
Copy link
Contributor

jferris commented Dec 8, 2014

Thanks for the feedback. I do think something like that could be good to see, and I don't think it would be too distracting from the chapter. I'll take a look at adding that in the next update.

@asymmetric
Copy link

Is there going to be an update? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants