Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symlink to symlink not caught #295

Open
mat-m opened this issue Jun 25, 2023 · 0 comments
Open

symlink to symlink not caught #295

mat-m opened this issue Jun 25, 2023 · 0 comments

Comments

@mat-m
Copy link
Contributor

mat-m commented Jun 25, 2023

Hello,

I thought we fixed this in a previous version.
I need to replay this in a sandbox, but from memory I did:

lsrc showed them:

➜  ~ lsrc 
[...]
/home/mm/.config/i3/config:/home/mm/.dotfiles/config/i3/config
/home/mm/.config/i3/i3blocks.conf:/home/mm/.dotfiles/config/i3/i3blocks.conf
[...]

I tried rcdn, but it didn't work as expected (maybe issue is on me because of args)

➜  ~ rcdn /home/mm/.config/i3/config /home/mm/.config/i3/i3blocks.conf                   
➜  ~ lsrc                                                             
[...]
/home/mm/.config/i3/config:/home/mm/.dotfiles/config/i3/config
/home/mm/.config/i3/i3blocks.conf:/home/mm/.dotfiles/config/i3/i3blocks.conf
[...]

And making them again with the tag:

➜  ~ mkrc -U -t i3 -v .config/i3                                      
Moving...
'/home/mm/.config/i3' -> '/home/mm/.dotfiles/tag-i3/config/i3'
Linking...
replacing identical but unlinked /home/mm/config/i3/config
removed '/home/mm/config/i3/config'
'/home/mm/.dotfiles/tag-i3/config/i3/config' -> '/home/mm/config/i3/config'
replacing identical but unlinked /home/mm/config/i3/i3blocks.conf
removed '/home/mm/config/i3/i3blocks.conf'
'/home/mm/.dotfiles/tag-i3/config/i3/i3blocks.conf' -> '/home/mm/config/i3/i3blocks.conf'

Here I am confused about /home/mm/config which it seems to have created based on -U flag

And finally I got:

╰─ ll .config/i3 
total 8,0K
drwxrwxr-x  2 mm mm 4,0K Jun 25 18:07 .
drwxr-xr-x 22 mm mm 4,0K Jun 25 18:02 ..
lrwxrwxrwx  1 mm mm   42 Jun 25 17:54 config -> /home/mm/.dotfiles/tag-i3/config/i3/config
lrwxrwxrwx  1 mm mm   49 Jun 25 17:54 i3blocks.conf -> /home/mm/.dotfiles/tag-i3/config/i3/i3blocks.conf
╭─    ~ ▓▒░······························································░▒▓ ✔ 
╰─ ll /home/mm/.dotfiles/tag-i3/config/i3                           
total 8,0K
drwxrwxr-x 2 mm mm 4,0K Jun 25 17:35 .
drwxrwxr-x 3 mm mm 4,0K Jun 25 17:38 ..
lrwxrwxrwx 1 mm mm   35 Jun 25 17:35 config -> /home/mm/.dotfiles/config/i3/config
lrwxrwxrwx 1 mm mm   42 Jun 25 17:35 i3blocks.conf -> /home/mm/.dotfiles/config/i3/i3blocks.conf

Symlink to dotfiles was caught by symlink with tag.
And we should not store symlinks to dotfiles. I would even say we should not store symlinks at all.
Any views on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant