Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing of container element #29

Closed
wants to merge 2 commits into from
Closed

Allow customizing of container element #29

wants to merge 2 commits into from

Conversation

schauerte
Copy link

I'm looking for ways to support custom layouts (like Flexgird or even more complex views) - something that cannot be achieved with custom fields only. At least, I was unable to do so because of missing control over the fields container element.

So I've added a possibility to replace the form view with a custom component (without adding breaking changes).

Is this a possible solution or should I try other routes? Do you accept merge requests for this at all? Please let me know, when anything needs adjustment to be merged.

This might close #11.

@MangelMaxime
Copy link
Contributor

Hello @schauerte,

I am not sure to understand the addition of this PR.

From, what I see in the changes you are allowing the user to not use the div element to put around the form and perhaps be able to use a form element?

Is it what your are trying to achieve with this PR ?

@schauerte
Copy link
Author

Thanks for your comment. I've added some documentation to explain the idea.

@MangelMaxime MangelMaxime mentioned this pull request Apr 13, 2021
Closed
@schauerte
Copy link
Author

The main goal was to assign custom CSS-classes to the container (to allow "easy" use of Flexbos/Cdd-Grid with Tailwind). After some more digging into CSS I've come to a working solution without this change. It is a bit hacky - since I have to repeat some things (like media-query breakpoints) Tailwind already defines in other ways - but the proposed changes were kind of hacky too.

So I'm closing this pull-request. Sorry for bothering and thank you very much for your great work!

@schauerte schauerte closed this May 3, 2021
@MangelMaxime
Copy link
Contributor

MangelMaxime commented May 3, 2021 •
edited
Loading

Hello @schauerte,

sorry I kind of always reported accepting this PR on my side too.

I think it is mostly due to the fact that I am working on Fable.Form which is a complete new form library created since the beginning with personalisation and extension in mind.

For example, on released day the project will consist on 3 packages:

  • Fable.Form: Library which defined a generic types/helpers that anyone can use to build their own Form logic
  • Fable.Form.Simple: Library which use Fable.Form as a foundation and implements how a form should work, what fields are supported, etc.
  • Fable.Form.Simple.Feliz.Bulma: View implemention for Fable.Form.Simple which is configurable and so someone can customise 100% of the rendering

And so anyone can implements their own Fable.Form.Simple or Fable.Form.Simple.Feliz.Bulma depending on their needs.

The packages are not yet released because I am working on cleaning up the examples and writing the documentation for it.

If you have a twitter account and want to be notified when the library will be released you can follow me on twitter.

I am already starting teasing in the open as I my goal is to hit a release this week: https://twitter.com/MangelMaxime/status/1389152779353174018

Edit: Thank you for the kind words ❤ and again sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FormBuilder and layout
2 participants
@schauerte @MangelMaxime