Remove extra leading space on neutral lines (fixes #16) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detouched
commented
Jun 7, 2018
| // Neutral line should have a space as its first character, | ||
| // however not all tools seem to obey this rule for empty lines (see Tortoise diff), | ||
| // so let's strip the first character if present. | ||
| String content = currentLine.substring(Math.min(1, currentLine.length())); |
There was a problem hiding this comment.
I don't use TortoiseSVN and can't test whether it actually strips out the line type symbol in case the actual line is empty, but making this .substring() call in a safe manner doesn't hurt anyway.
There was a problem hiding this comment.
Actually it looks like there's an issue #9 about TortoiseSVN example specifically. Maybe the example is incorrect?
| package io.reflectoring.diffparser.unified; | ||
|
|
||
| import io.reflectoring.diffparser.api.model.Line; | ||
| import junit.framework.Assert; |
There was a problem hiding this comment.
Later I noticed that there's a mess with TestNG vs Junit dependencies, which I fixed in my other PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an extra leading character in a safe manner.