Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete line marker is parsed as a neutral line #17

Open
detouched opened this issue Jun 7, 2018 · 0 comments
Open

Incomplete line marker is parsed as a neutral line #17

detouched opened this issue Jun 7, 2018 · 0 comments

Comments

@detouched
Copy link

The diff tools use a special line to report about absence of the trailing newline character aka incomplete line (some report when it differs between the compared files, others report always):
\ No newline at end of file

This line is currently parsed as a neutral line, but in fact it always belongs to either of the diff sides. Its content should probably not reported as is.

detouched added a commit to detouched/diffparser that referenced this issue Jun 7, 2018
…bergs#17, thombergs#20)

- Incomplete marker lines are not parsed as NEUTRAL lines anymore,
  they are set as a flag on a Diff for either of the diff side instead.
  This is a potentially breaking change, so version bumped to 2.0.
- TestNG used to pull in JUnit as a direct dependency, and test classes
  used to use a mixture of TestNG and JUnit assertions. This commit
  bumps TestNG to a recent 6.14.3 which doesn't have JUnit anymore,
  and adjusts the tests to use TestNG assertions only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant