Add many hash functions #1695
Merged
Add many hash functions #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
force-pushed
the
lg/hash-more
branch
from
e6d44b6
to
1250a61
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1695 +/- ##
==========================================
+ Coverage 75.93% 75.95% +0.02%
==========================================
Files 362 362
Lines 114328 114378 +50
==========================================
+ Hits 86812 86878 +66
+ Misses 27516 27500 -16
|
thofma
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of progress towards oscar-system/Oscar.jl#2222 and #1594.
I tried to use as much information from the corresponding
==method to make the hash as good as possible.Once this is merged and released, could you @thofma update the list in #1594 (I'll do the same for oscar-system/Oscar.jl#2222), so that we can see what's left to work on?