Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show method for pseudo-matrices #1689

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

SirToby25
Copy link
Contributor

Previously, generating a pseudo-matrix over an algebraic number field with zero rows was possible, e.g.,

K, _ = quadratic_field(-5)
P = pseudo_matrix(identity_matrix(K, 0), [])

and the pseudo-matrix P was created correctly. However, an error was raised, due to an undefined reference and this P could not be printed. This commit just adds an extra output for pseudo-matrices with zero rows.

Added an output for pseudo-matrices with zero rows that
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.99%. Comparing base (5b4309e) to head (3fe5f78).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/NumFieldOrd/NfOrd/LinearAlgebra.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1689       +/-   ##
===========================================
+ Coverage    5.68%   75.99%   +70.31%     
===========================================
  Files         362      362               
  Lines      114128   114327      +199     
===========================================
+ Hits         6485    86884    +80399     
+ Misses     107643    27443    -80200     
Files with missing lines Coverage Δ
src/NumFieldOrd/NfOrd/LinearAlgebra.jl 57.25% <0.00%> (+57.11%) ⬆️

... and 322 files with indirect coverage changes

---- 🚨 Try these New Features:

@thofma thofma enabled auto-merge (squash) November 20, 2024 19:41
@thofma
Copy link
Owner

thofma commented Nov 20, 2024

Thanks

@thofma thofma merged commit b9aaec0 into thofma:master Nov 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants