mount resource cannot be remounted, allow distinguishing title and path in glusterfs::mount #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christophe Vanlancker <[email protected]>
…ouble entries in fstab Signed-off-by: Christophe Vanlancker <[email protected]>
carroarmato0
changed the title
|
this looks really good, @carroarmato0! i hope @thias gets around to merging it 👍! |
|
Please accept this pull request as it is blocking us from being able to use this module. |
|
@sharkannon i'm working on fix-up of this module, you can use my branch from #14. mod 'glusterfs', :git => 'git://github.com/igalic/puppet-glusterfs.git', :ref => 'fixes' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gluster Fuse module unfortunately does not support the '-o remount' flag (yet ?)
Setting it to false gives puppet peace. When changing mount options it seems to refresh the resource. Not sure if the refresh actually does anything, but at least the fstab entry get updated correctly.
The other commit allows you to specify the path of the mountpoint while keeping a uniqe resource title. This is important to have puppet make the correct modifications in /etc/fstab when you change some options to the same resource instead of adding one below potentially causing issues after a reboot due to double entries.
Signed-off-by: Christophe Vanlancker [email protected]