Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store pruning tables for 4x4 #461

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gregorbg
Copy link
Member

Turns out that due to a programming mistake, 4x4 pruning tables were never stored and therefore re-computed on every run of the program.

We can save considerable memory (especially in cloud environments) by storing the pruning files on disk.

@campos20
Copy link
Member

Interesting. 4x4 takes forever to generate. Can you also check sq-1 as well?

@gregorbg
Copy link
Member Author

This change should actually stimulate the exact opposite behaviour. I'll keep an eye on it but it's not on top of my ToDo list right now :/

@gregorbg
Copy link
Member Author

Re-triggering…

@gregorbg gregorbg closed this Feb 18, 2020
@gregorbg gregorbg reopened this Feb 18, 2020
@gregorbg gregorbg force-pushed the feature/pruning branch 4 times, most recently from 439d310 to c99428c Compare February 18, 2020 11:24
@gregorbg gregorbg changed the title Store pruning tables for 4x4 WIP: Store pruning tables for 4x4 Feb 18, 2020
@gregorbg
Copy link
Member Author

Labelling this as WIP since it's unclear whether the I/O of pruning tables actually provides an advantage over raw initialization every time

@gregorbg gregorbg marked this pull request as draft May 21, 2020 14:24
@gregorbg gregorbg changed the title WIP: Store pruning tables for 4x4 Store pruning tables for 4x4 May 21, 2020
@gregorbg gregorbg force-pushed the master branch 2 times, most recently from d82b6b6 to 46178e0 Compare September 6, 2020 18:53
@gregorbg gregorbg force-pushed the master branch 2 times, most recently from 1420f0e to d66eb2d Compare April 19, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants