-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store pruning tables for 4x4 #461
Draft
gregorbg
wants to merge
2
commits into
thewca:master
Choose a base branch
from
gregorbg:feature/pruning
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interesting. 4x4 takes forever to generate. Can you also check sq-1 as well? |
This change should actually stimulate the exact opposite behaviour. I'll keep an eye on it but it's not on top of my ToDo list right now :/ |
gregorbg
force-pushed
the
feature/pruning
branch
from
December 29, 2019 22:10
26da1a8
to
f8e1c6d
Compare
gregorbg
force-pushed
the
feature/pruning
branch
2 times, most recently
from
January 8, 2020 11:23
bd79c97
to
0233ed7
Compare
gregorbg
force-pushed
the
feature/pruning
branch
from
January 8, 2020 15:37
0233ed7
to
6ac1ba2
Compare
gregorbg
force-pushed
the
feature/pruning
branch
from
January 18, 2020 11:08
6ac1ba2
to
2c457b4
Compare
gregorbg
force-pushed
the
feature/pruning
branch
2 times, most recently
from
February 18, 2020 09:28
0d7da31
to
1189a8c
Compare
Re-triggering… |
gregorbg
force-pushed
the
feature/pruning
branch
4 times, most recently
from
February 18, 2020 11:24
439d310
to
c99428c
Compare
gregorbg
changed the title
Store pruning tables for 4x4
WIP: Store pruning tables for 4x4
Feb 18, 2020
Labelling this as WIP since it's unclear whether the I/O of pruning tables actually provides an advantage over raw initialization every time |
gregorbg
changed the title
WIP: Store pruning tables for 4x4
Store pruning tables for 4x4
May 21, 2020
gregorbg
force-pushed
the
master
branch
2 times, most recently
from
September 6, 2020 18:53
d82b6b6
to
46178e0
Compare
gregorbg
force-pushed
the
master
branch
2 times, most recently
from
April 19, 2021 09:23
1420f0e
to
d66eb2d
Compare
gregorbg
force-pushed
the
feature/pruning
branch
from
January 6, 2024 01:17
c99428c
to
4f4dbd5
Compare
gregorbg
force-pushed
the
feature/pruning
branch
from
January 6, 2024 01:26
05662d3
to
28d0cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that due to a programming mistake, 4x4 pruning tables were never stored and therefore re-computed on every run of the program.
We can save considerable memory (especially in cloud environments) by storing the pruning files on disk.