[stable-v2.11] Tools: Topology2: SDW: Use for PCH DMIC IIR type with +20 dB gain #9698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgirdwood
approved these changes
Dec 2, 2024
kv2019i
reviewed
Dec 2, 2024
| @@ -79,6 +79,7 @@ Define { | |||
| SDW_JACK_CAPTURE_CH 2 | |||
There was a problem hiding this comment.
It's not yet merged to git main from #9690 . Should I make a separate PR for this?
There was a problem hiding this comment.
Now done. I did it with git cherry-pick -x 9fd7ef7327e8bd8b299c1295c05610f8b2764180 , and fixed the conflict with other defines lines added into main.
The existing default is high-pass 40 Hz with 0 dB gain. This change amplifies captured sound from DMIC by 20 dB. The same amplifying IIR type is used in hda-generic. The change is for now, but not the final solution. After we have UCM2 control for capture processing in SOF we can shift applying more gain to the DRC component that will provide more robustness with silent and loud environments. Signed-off-by: Seppo Ingalsuo <[email protected]> (cherry picked from commit 9fd7ef7)
singalsu
force-pushed
the
stable_211_sdw_dmic_use_iir_capture_gain
branch
from
21f7ef2 to
280caa7
Compare
kv2019i
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing default is high-pass 40 Hz with 0 dB gain. This change amplifies captured sound from DMIC by 20 dB. The same amplifying IIR type is used in hda-generic.
The change is for now, but not the final solution. After we have UCM2 control for capture processing in SOF we can shift applying more gain to the DRC component that will provide more robustness with silent and loud environments.