Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topology2: Add HDA with DMIC, HDMI topologies support for ACE3 architecture #9696

Merged
merged 1 commit into from
Dec 3, 2024
Merged

topology2: Add HDA with DMIC, HDMI topologies support for ACE3 architecture #9696

merged 1 commit into from
Dec 3, 2024

Conversation

udaymb
Copy link
Contributor

@udaymb udaymb commented Nov 29, 2024

This entry creates a topology for the HDA codec with PDM0 DMIC for PTL.

ujfalusi
ujfalusi approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@ujfalusi ujfalusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, ACE3 needs new DMIC blob after all...

@singalsu
Copy link
Collaborator

OK, ACE3 needs new DMIC blob after all...

Yes it does, please add also build for ace2 tplg, they all are different HW IP.

singalsu
singalsu approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @udaymb !

@ujfalusi
Copy link
Contributor

OK, ACE3 needs new DMIC blob after all...

Yes it does, please add also build for ace2 tplg, they all are different HW IP.

I tried to see the difference, but the blob is the same for all ACE platforms, the reserved bits/register handling is all done in zephyr driver, the blob parsing is identical. Also, @udaymb said that the ac1 blob works on PTL fine (which is not a surprise).

@singalsu
Copy link
Collaborator

OK, ACE3 needs new DMIC blob after all...

Yes it does, please add also build for ace2 tplg, they all are different HW IP.

I tried to see the difference, but the blob is the same for all ACE platforms, the reserved bits/register handling is all done in zephyr driver, the blob parsing is identical. Also, @udaymb said that the ac1 blob works on PTL fine (which is not a surprise).

No, it's not same, see:

https://github.com/alsa-project/alsa-utils/blob/d45a2be9eaba2bb75840ca7c19bccc4d6578270b/topology/nhlt/intel/dmic/dmic-process.c#L790

@udaymb udaymb force-pushed the ptl-hda-pdm0-dmic branch 3 times, most recently from 081390d to 099aceb Compare December 2, 2024 07:08
@udaymb udaymb changed the title topology2: Add topology support for PDM0 DMIC with HDA codec for PTL topology2: Add HDA with DMIC, HDMI topologies support for ACE3 architecture Dec 2, 2024
@udaymb
topology2: Add HDA with DMIC, HDMI topologies support for ACE3 archit…
f6b76b5 
…ecture

These entries creates multiple topologies for the HDA codec with 2, 4
DMICs and HDMI for ACE 3 architecture

Signed-off-by: Uday M Bhat <[email protected]>
@udaymb udaymb force-pushed the ptl-hda-pdm0-dmic branch from 099aceb to f6b76b5 Compare December 2, 2024 08:50
@kv2019i
Copy link
Collaborator

kv2019i commented Dec 3, 2024

SOFCI TEST

@kv2019i
Copy link
Collaborator

kv2019i commented Dec 3, 2024

sof-docs fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3A%22Known+PR+Failures%22+

@kv2019i kv2019i merged commit 0b3ee3a into thesofproject:main Dec 3, 2024
41 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singalsu singalsu singalsu approved these changes

@ujfalusi ujfalusi ujfalusi approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@bardliao bardliao bardliao approved these changes

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@jsarha jsarha Awaiting requested review from jsarha jsarha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@udaymb @singalsu @ujfalusi @kv2019i @bardliao @lgirdwood