remove platform lib/dai.h from SOF Zephyr builds #9653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
requested review from
RanderWang,
marcinszkudlinski,
pblaszko,
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
26 tasks
|
Stub build is failing. I think #9651 will help with this. Current chain_dma.c require HDA drivers to be enabled in the build. Will confirm. |
lgirdwood
reviewed
Nov 14, 2024
| /* copier id = (group id << 4) + codec id + IPC4_ALH_DAI_INDEX_OFFSET | ||
| * dai_index = (group id << 8) + codec id; | ||
| */ | ||
| #define IPC4_ALH_DAI_INDEX(x) ((((x) & 0xF0) << DAI_NUM_ALH_BI_DIR_LINKS_GROUP) + \ | ||
| #define IPC4_ALH_DAI_INDEX(x) ((((x) & 0xF0) << IPC4_DAI_NUM_ALH_BI_DIR_LINKS_GROUP) + \ |
There was a problem hiding this comment.
Btw, should this be in Zephyr now ?
There was a problem hiding this comment.
@lgirdwood I took a look at this, but we don't really have a good schema for ALH instances in DT, and on newer platforms (ace20 onwards), this is really replaced by the HDA link DMA. And to add to that, this bi-dir-link group is really only used to parse the blob, so it's not even strictly tied to hw interface and its use, so in the end did not seem worth the effort.
The alh.h headers have used SOF platform layer to handle differences between different Intel ALH generations. In the end the only difference is the encoding used for DAI index. Move the variation to ipc4/alh.h directly as this only affects Intel builds with ALH support. Signed-off-by: Kai Vehmanen <[email protected]>
Stop using platform layer to query number of SSP instances and number of HDA in/out DMA channels. The hardware specific information is already defined in device tree data, so no need to have same information duplicated in SOF platform layer. Signed-off-by: Kai Vehmanen <[email protected]>
To calculate the gateway count in hardware config IPC response, ALH bidirection link count is needed. Instead of pulling this from the SOF platform layer, use the ipc4/alh.h directly as it now has this information. Signed-off-by: Kai Vehmanen <[email protected]>
Stop using the SOF platform layer and directly pull the hardware properties from devicetree. Signed-off-by: Kai Vehmanen <[email protected]>
Use of native Zephyr DAIs has no dependency to SOF platform definitions anymore, so this include can be removed. Signed-off-by: Kai Vehmanen <[email protected]>
No longer needed for Zephyr builds, can be removed as unused. Signed-off-by: Kai Vehmanen <[email protected]>
No longer needed for Zephyr builds, can be removed as unused. Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
force-pushed
the
202411-plat-dai-h-removal
branch
from
b2f426e to
c9fd56c
Compare
|
V2 pushed:
|
lyakh
approved these changes
Nov 15, 2024
tmleman
approved these changes
Nov 18, 2024
lgirdwood
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patch series the convert remaining use of platform lib/dai.h in SOF cmmon code to either device-tree (in generic code) or simple ifdefs (in vendor specific compiliation units).
In the end of series, remove the lib/dai.h definitions for all Zephyr-only SOF platforms.
Link: #5794