Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Tune: TDFB: Add generate of few needed blobs #9147

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

singalsu
Copy link
Collaborator

@singalsu singalsu commented May 21, 2024

See commit texts for descriptions.

@singalsu singalsu marked this pull request as ready for review May 22, 2024 09:52
@singalsu singalsu requested a review from ShriramShastry May 22, 2024 09:53
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a ```sof`-`` prefix for all tools and put the tools in the module directories.

@singalsu
Copy link
Collaborator Author

Can we have a ```sof`-`` prefix for all tools and put the tools in the module directories.

Yep, maybe I should postpone this and do the tools move first. There will be a bit more blobs add later, e.g. a blob for analog mic DRC.

@lgirdwood lgirdwood added this to the v2.11 milestone Jun 18, 2024
@kv2019i
Copy link
Collaborator

kv2019i commented Sep 6, 2024

Release reminder - one week to v2.11-rc1.

@kv2019i
Copy link
Collaborator

kv2019i commented Sep 13, 2024

FYI @singalsu , pushing to v2.12.

@kv2019i kv2019i modified the milestones: v2.11, v2.12 Sep 13, 2024
@singalsu singalsu marked this pull request as draft October 10, 2024 15:36
This patch adds a few blobs generate for the beamformer. There is
no need to update the blobs in tplg2 since the update has been
already done with run of an earlier version of this patch.

- Support two mic line array with 74 mm spacing with addition to
  sof_example_line_array.m and sof_example_two_beams.m

- Updates beamformer pass-through configuration blob with
  steer angle to avoid initialize error.

- Adds script sof_example_two_beams_default.m to export generic
  blobs for 2 and 4 mic line arrays. The parameters are such that
  the array mic spacing is not critical (delay-and-sum type) and
  narrow user faced stereo beams. The two beams design functions
  are split to own files for use from two scripts.

Signed-off-by: Seppo Ingalsuo <[email protected]>
@singalsu singalsu force-pushed the tune_tdfb_generic_blobs_export branch from 3cc4402 to fc21c47 Compare November 25, 2024 12:11
This change adds generate of multi-microphone beamformer blobs to
apply with UCM2 rules for SOF.

Signed-off-by: Seppo Ingalsuo <[email protected]>
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we may want something in the beamformer Readme.md that describes the tool and usage.

@singalsu
Copy link
Collaborator Author

singalsu commented Nov 25, 2024

LGTM, but we may want something in the beamformer Readme.md that describes the tool and usage.

Yep, I added it in the 3rd commit.

@singalsu singalsu force-pushed the tune_tdfb_generic_blobs_export branch from 71c3698 to abe580e Compare November 25, 2024 15:24
@singalsu singalsu marked this pull request as ready for review November 25, 2024 15:25
@singalsu singalsu requested a review from lgirdwood November 26, 2024 11:02
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent inline docs and README file on top! No blockers.

@@ -0,0 +1,41 @@
# Settings blobs generators for TDFB

This directory contains the scripts to generate settgings blobs for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: settgings

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed now!

This patch adds a README.md file that explains how various
blob generate scrips are used.

Signed-off-by: Seppo Ingalsuo <[email protected]>
@singalsu singalsu force-pushed the tune_tdfb_generic_blobs_export branch from abe580e to 5f7e422 Compare November 27, 2024 12:06
@kv2019i
Copy link
Collaborator

kv2019i commented Dec 3, 2024

sof-docs fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3A%22Known+PR+Failures%22+

@kv2019i kv2019i merged commit 70b692e into thesofproject:main Dec 3, 2024
42 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants