Tools: Tune: Multiband-DRC: Add comment about generator script #8142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch helps to find the right tool to create the setup blobs. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
ShriramShastry
approved these changes
Sep 1, 2023
lgirdwood
approved these changes
Sep 1, 2023
lgirdwood
approved these changes
Sep 13, 2023
| @@ -139,7 +139,7 @@ function export_multiband_drc(prm) | |||
| endian, 4); | |||
|
|
|||
| tplg_write(tplg1_fn, blob8, "MULTIBAND_DRC"); | |||
| tplg2_write(tplg2_fn, blob8_ipc4, "multiband_drc_config", 'Exported Control Bytes'); | |||
| tplg2_write(tplg2_fn, blob8_ipc4, "multiband_drc_config", "Exported with script example_multiband_drc.m"); | |||
There was a problem hiding this comment.
btw, next steps would be to include the command line and tool version used to generate the data so that any developer can reproduce.
There was a problem hiding this comment.
Yep, we can use more comment estate than this with a bit more changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch helps to find the right tool to create the setup blobs.