Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topology2: cavs-rt5682: use macros for all PCM IDs #8130

Merged
merged 1 commit into from
Aug 31, 2023
Merged

topology2: cavs-rt5682: use macros for all PCM IDs #8130

merged 1 commit into from
Aug 31, 2023

Conversation

yongzhi1
Copy link
Contributor

Make it less error-prone for maintenance.

@yongzhi1
topology2: cavs-rt5682: use macros for all PCM IDs
26216b1 
Make it less error-prone for maintenance.

Signed-off-by: Yong Zhi <[email protected]>
lgirdwood
lgirdwood reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @yongzhi1 - do we need to do for all topologies ?
@ranj063 @jsarha pls review.

jsarha
jsarha approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@jsarha jsarha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always for a common definition on any value used in multiple places. Makes the topology sources more readable.

@lgirdwood lgirdwood merged commit 107043f into thesofproject:main Aug 31, 2023
40 of 41 checks passed
@yongzhi1 yongzhi1 deleted the pcm-ids branch August 31, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgirdwood lgirdwood lgirdwood left review comments

@ranj063 ranj063 ranj063 approved these changes

@jsarha jsarha jsarha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yongzhi1 @jsarha @ranj063 @lgirdwood