[DNM] POC: ] Direct use of cached / not-cached shared memory alias instead of coherent.h in case of buffers #8013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcinszkudlinski I assume you will continue with updates for teh TODOs here so that CI will turn all Green ? |
2 tasks
marcinszkudlinski
force-pushed
the
shared_memory_comp_buffer
branch
3 times, most recently
from
11e19cf to
eebc9ba
Compare
This commit is a POC that removes coherent.h from struct comp_buffer As sharing status of a buffer is known at creation time, it is enough to create a buffer in shared (not cached mem alias) when it will be used by several cores Signed-off-by: Marcin Szkudlinski <[email protected]>
Removes all instances of buffer_acquire function usage Signed-off-by: Tobiasz Dryjanski <[email protected]>
Source/sink interfce will be treated in the same way as buffers, either cached or not as needed Sparse markings should be removed Signed-off-by: Marcin Szkudlinski <[email protected]>
Source/sink interfce will be treated in the same way as buffers, either cached or not as needed Sparse markings should be removed Signed-off-by: Marcin Szkudlinski <[email protected]>
audio stream is no longer required to have __sparse mark remove __sparse from container_of Signed-off-by: Marcin Szkudlinski <[email protected]>
audio stream is no longer required to have __sparse mark remove __sparse from all audio_stream functions Signed-off-by: Marcin Szkudlinski <[email protected]>
Signed-off-by: Tobiasz Dryjanski <[email protected]>
Signed-off-by: Tobiasz Dryjanski <[email protected]>
Signed-off-by: Tobiasz Dryjanski <[email protected]>
Signed-off-by: Tobiasz Dryjanski <[email protected]>
buffer_acquire and buffer_release are no longer in use remove stubs from the code Signed-off-by: Marcin Szkudlinski <[email protected]>
lyakh
requested changes
Sep 1, 2023
| @@ -319,7 +319,7 @@ __must_check static inline struct coherent __sparse_cache *coherent_acquire(stru | |||
| dcache_invalidate_region(cc, size); | |||
| } | |||
|
|
|||
| return (__sparse_force struct coherent __sparse_cache *)c; | |||
| return c; | |||
There was a problem hiding this comment.
why these changes? I'd expect coherent.h to remain unchanged, unless there are bugs there, but fixing any would be a separate piece of work?
There was a problem hiding this comment.
@lyakh I should not use this branch for CI check ;)
You're right, this change is incorrect
marcinszkudlinski
force-pushed
the
shared_memory_comp_buffer
branch
from
eebc9ba to
be92e40
Compare
|
Closing this POC as it was accidently used as CI test branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a quick POC for discussuion #8006
There are a lot of TODOs, yet it is ready to be tested in IPC4/MTL
TODOs:
In not-shared there's no need for locks because LLs are processed one by one in a single thread