From 805364f74eb022107b667375f237a69f366e02a1 Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Sat, 24 Aug 2024 00:02:21 +0000 Subject: [PATCH] intel_adsp_ace15_mtpm.conf: replace blanket _STUBS with focused RTC MOCK CONFIG_COMP_STUBS=y was enabled in #8722 / commit 8e34109e105a ("AEC: Enable Google AEC with Mock compliation"). CONFIG_COMP_STUBS indirectly enables CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK which was the desired effect. However it also automatically and silently "mocks" all other 3rd party modules which is not desirable. So, replace it with the more focused `CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK`. `src/audio/Kconfig` says "CONFIG_STUBS: This should only be used in testing environments like fuzzers or CI." It's not clear why official sof-bin releases should include `google_rtc_audio_processing_mock.c` but that's another topic for another day. build-mtl/zephyr.strip is identical before versus after this commit. Signed-off-by: Marc Herbert --- app/boards/intel_adsp_ace15_mtpm.conf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/boards/intel_adsp_ace15_mtpm.conf b/app/boards/intel_adsp_ace15_mtpm.conf index 293ffe747e82..bcd2b122c7f3 100644 --- a/app/boards/intel_adsp_ace15_mtpm.conf +++ b/app/boards/intel_adsp_ace15_mtpm.conf @@ -104,7 +104,9 @@ CONFIG_PROBE=y CONFIG_PROBE_DMA_MAX=2 CONFIG_LOG_TIMESTAMP_64BIT=y +# Not sure why this is part of official sof-bin releases? +# See #8722 and #9386 CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING=y -CONFIG_COMP_STUBS=y +CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK=y CONFIG_KCPS_DYNAMIC_CLOCK_CONTROL=y