Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of tp/fp/rude on the Comment table #46

Open
scohe001 opened this issue Feb 3, 2020 · 0 comments
Open

Get rid of tp/fp/rude on the Comment table #46

scohe001 opened this issue Feb 3, 2020 · 0 comments

Comments

@scohe001
Copy link
Collaborator

scohe001 commented Feb 3, 2020

With the advent of the Feedbacks table, storing tp/fp/rude int's on the Comment is now redundant.

That being said, everything looking at tp/fp/rude numbers is looking at those columns, so this may be a bit of an undertaking.

What will likely need to be done:

  • Remove tp/fp/rude int columns on the Comment table
  • Add some easy way to fetch tp/fp/rude numbers for a column
    • Maybe a view? Or the SQLite equivalent? Or just a function on the Comment class that returns a map?
  • Update all code fetching/updating those values to ensure that it's fetching/updating Feedbacks instead
  • Write a migration script or SQLite query to create Feedback rows from anonymous users (maybe user id -1) for all of the legacy comments before this db table was added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant