Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with symlink in lib/dependencies.sh #1

Open
lakamsani opened this issue Nov 3, 2017 · 0 comments
Open

problem with symlink in lib/dependencies.sh #1

lakamsani opened this issue Nov 3, 2017 · 0 comments

Comments

@lakamsani
Copy link

Hi,

I found and fixed a problem with symbolic link in lib/dependencies.sh that was causing cf push app -b [email protected]:theodo/nodejs-oracledb-buildpack.git to fail when trying to npm install oracledb. Here is the commit where I fixed it.

lakamsani@8f0a76e

Now cf push app -b [email protected]:lakamsani/nodejs-oracledb-buildpack.git works.

Not sending a PR because I also changed manifest.xml to use just node 8.8.0 (removed all other node versions) and not everyone may want that part. Feel free to grab the symlink fix as I can confirm it fixed the issue with npm install oracledb. Here is the CF/IBM Cloud version I tested with.

{
   "name": "Bluemix",
   "build": "253033",
   "support": "http://ibm.biz/bluemix-supportinfo",
   "version": 0,
   "description": "IBM Bluemix",
   "authorization_endpoint": "https://login.ng.bluemix.net/UAALoginServerWAR",
   "token_endpoint": "https://uaa.ng.bluemix.net",
   "min_cli_version": null,
   "min_recommended_cli_version": null,
   "api_version": "2.75.0",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant