Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Update RUN/COMPILE functions for the datasets #18

Open
gabrielasd opened this issue Feb 2, 2024 · 1 comment
Open

[Release] Update RUN/COMPILE functions for the datasets #18

gabrielasd opened this issue Feb 2, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gabrielasd
Copy link
Collaborator

gabrielasd commented Feb 2, 2024

A) The "run" functions for each dataset (esp. HCI) should be checked and made up to date, and one should be able to run it as a script on ComputeCanada. The "compile" functions should be also kept up to date, with all of the available properties computed from the raw data.

B) Finally, after the API and list of properties is finalized, and before release, all of the currently available datasets should be run and compiled, and the .msg files included in the Github repo, and in the library itself.

@gabrielasd gabrielasd added enhancement New feature or request help wanted Extra attention is needed labels Feb 2, 2024
@gabrielasd
Copy link
Collaborator Author

gabrielasd commented Feb 2, 2024

This was issue 37 ported from the QuantumElephant repo.

Part B) of this commit message overlaps with issues #8

@msricher, for part A) my question is whether this is a feature for the current version of atomdb, where the compile and run functions are sort of the same thing, or for the future version on the GSoC proposal? In specific the part about being able to sun as script in compute Canada.
My confusion comes because I remember that initially, for the HCI database, we had a script function (run) that ran the jobs in compute Canada, and then a compile one that processed the data, or something along those lines. While now, there is only the task of processing the raw data where the compile function calls the run function.
At some point we removed the requirement that atomdb ran the jobs to generate raw data, I think there were two reasons; one was that the databases project had this purpose, and the other that from the 5 datasets, only the HCI jobs would have this separation of tasks (although we could make the same for the Gaussian ones). And I think there was also the discussion about whether we would keep track of different versions/updates of datasets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant