Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Investigate thenewboston-node Document how the features implemented affects the JS SDK #126

Open
zinoadidi opened this issue Apr 3, 2021 · 8 comments
Assignees
Labels
good first issue Good for newcomers ready task ready for development third-party tasks outside tnb-js sdk

Comments

@zinoadidi
Copy link
Contributor

zinoadidi commented Apr 3, 2021

Task

Contributors are able to complete this task and earn thenewboston coins. Check out the labels to learn how much you can earn for contributing by completing this task. Please make sure to be honest if you wish to contribute by saying you can't finish this and we can just un-assign you with no harm done! There is no point in delaying tasks from being completed for miscommunication!

Overview

In https://github.com/thenewboston-developers/thenewboston-node/tree/master/thenewboston_node/business_logic/tests
You will find different tests for features that are internal as well as possible exposable features.
Compile a list of tests that could be as part of the final API documentation when this task will be ready thenewboston-blockchain/thenewboston-node#29

Note: this task is ongoing and should be visited as new tests are added or more clarification is gotten from the team working on tnb node

Submit a google doc with the list of tests/features which look like public features as well as possible places where they can fit in our existing system or as part of a brand new set of classes.

Behavior

  • a living document that identifies and groups possible features based on existing tests.

Please ask for this task to be assigned to you and earn and its sweet reward 😉

Remember to include your account number in your PR description for us to pay you 💰

** Pull Requests **
All Pull Request should be made to development branch, read contributors guild for more information about contributing

@zinoadidi zinoadidi added the PR Reward - 750 Reward in coin(s) label Apr 3, 2021
@zinoadidi zinoadidi changed the title [Task] Investigate tests and identify possible features that can be as endpoints / part of the API (POC) [Task] Investigate tests in thenewboston-node and identify possible features that can be as endpoints / part of the API (POC) Apr 3, 2021
@zinoadidi zinoadidi changed the title [Task] Investigate tests in thenewboston-node and identify possible features that can be as endpoints / part of the API (POC) [Task] Investigate tests in thenewboston-node and identify possible features that can be as endpoints / part of the public API (POC) Apr 3, 2021
@zinoadidi zinoadidi added ready task ready for development third-party tasks outside tnb-js sdk good first issue Good for newcomers labels Apr 3, 2021
@zinoadidi zinoadidi changed the title [Task] Investigate tests in thenewboston-node and identify possible features that can be as endpoints / part of the public API (POC) [Task] Investigate the tests in thenewboston-node and identify possible features that can be as endpoints / part of the public API (POC) Apr 3, 2021
@dmugtasimov
Copy link

@zinoadidi Please, be aware that the API will be ready after this task is completed: thenewboston-blockchain/thenewboston-node#29

@zinoadidi
Copy link
Contributor Author

zinoadidi commented Apr 3, 2021

@dmugtasimov, the Plan is to keep the sdk development in sync so that BETA features are available as soon as they are ready on node or a few weeks after

That's why I wrote earlier asking about documentation.

It would be nice if the apis are made as features are completed rather than at the end of the whole thing so we can follow as well and make corrections were necessary.

In a nut shell we are not interested in creating apis we just need to know what features are available what data is needed to send and what output

@zinoadidi zinoadidi changed the title [Task] Investigate the tests in thenewboston-node and identify possible features that can be as endpoints / part of the public API (POC) [Task] The tests in thenewboston-node may contain information about possible features and data / output to expect from future endpoints (POC) Apr 3, 2021
@zinoadidi zinoadidi changed the title [Task] The tests in thenewboston-node may contain information about possible features and data / output to expect from future endpoints (POC) [Task] The tests in thenewboston-node may contain information about possible features and input / output to expect from future endpoints (POC) Apr 3, 2021
@mrbusysky
Copy link
Contributor

Maybe It's time to make a branch called beta.

@zinoadidi
Copy link
Contributor Author

zinoadidi commented Apr 5, 2021

yes @mrbusysky the branch comes sooner;
I just need a concrete task that will go into it + I want all changes that come from Account manager integration to be done before switching focus/attention

@tomijaga
Copy link
Contributor

tomijaga commented Apr 7, 2021

I'll work on this

@tomijaga
Copy link
Contributor

@dmugtasimov
Copy link

subscribe to this task thenewboston-blockchain/thenewboston-node#29 . the description may be useful

@tomijaga
Copy link
Contributor

tomijaga commented Apr 29, 2021

https://docs.google.com/document/d/1r_Zd5jOdS2teXQwuKYtDpkPOnr99jOFYbzKIPxAPdGs/edit?usp=sharing

@buckyroberts buckyroberts removed the PR Reward - 750 Reward in coin(s) label May 8, 2021
@zinoadidi zinoadidi changed the title [Task] The tests in thenewboston-node may contain information about possible features and input / output to expect from future endpoints (POC) [Task] Investigate thenewboston-node Document how the features implemented affects the JS SDK Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ready task ready for development third-party tasks outside tnb-js sdk
Projects
None yet
Development

No branches or pull requests

5 participants