Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window Size does not remain same #512

Open
YashovardhanSingh opened this issue Nov 24, 2020 · 13 comments
Open

Window Size does not remain same #512

YashovardhanSingh opened this issue Nov 24, 2020 · 13 comments

Comments

@YashovardhanSingh
Copy link

Bug Description
The window size of the TNB Account Manager does not remain the same as the size when it was closed previously.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Open TNB Account Manager
  2. adjust its size
  3. Close the Manager
  4. Open again

Expected behavior
The window size should remain the same as the size when it was closed previously.

Actual behavior
The window size does not remain the same.

OS and Browser

  • OS: Windows 10

Account Number
38a99b8f1916eab0471ca1df26e7fe5e71d845e6ea5b233cd3d93a75097ea2d6

@YashovardhanSingh
Copy link
Author

@angle943 Is there no Bug bounty?

@stweyel
Copy link
Contributor

stweyel commented Feb 14, 2021

This BTW is not only Win related. Same behaviour on MacOS. If that's going to change the window position should be considered to be saved as well. Maybe more a question of design than a bug?

94161c7f2d143eb387aab95b1ee4d334df57a233a63bd466c8b2368148c4917d

@AbhayAysola
Copy link
Contributor

AbhayAysola commented Mar 28, 2021

@angle943 we could use this package for window state management or implement it on our own as to not increase bloat.

This gist could also work.

This file in electron boilerplate might work as well.

@stweyel
Copy link
Contributor

stweyel commented Mar 28, 2021

Will anybody be assigned for that? Would it be ok if i do a PR @angle943 ,@AbhayAysola ?

@AbhayAysola
Copy link
Contributor

Sure, I'd wait for @angle943 's reply though. @stweyel

@angle943
Copy link
Contributor

sure, anyone can work on this @stweyel and @AbhayAysola

@stweyel
Copy link
Contributor

stweyel commented Mar 30, 2021

sure, anyone can work on this @stweyel and @AbhayAysola

Great! Got it already running. Need to sort out a thing and do some testing before submitting a PR.

@YashovardhanSingh
Copy link
Author

Is this task complete?

@angle943
Copy link
Contributor

Yes now it is. @YashovardhanSingh and @stweyel you guys will receive a payment soon. I've submitted a bounty request: thenewboston-blockchain/Contributor-Payments#259

@manishram
Copy link
Contributor

With reference to this: thenewboston-blockchain/Contributor-Payments#259

@angle943 can you please send coins to @YashovardhanSingh and @stweyel

@angle943
Copy link
Contributor

angle943 commented May 7, 2021

@YashovardhanSingh @stweyel terribly sorry you guys! I had the amount just sitting in the FE wallet. I've sent out the two payments!

@stweyel
Copy link
Contributor

stweyel commented May 7, 2021

@YashovardhanSingh @stweyel terribly sorry you guys! I had the amount just sitting in the FE wallet. I've sent out the two payments!

Thanks!

@Creatinas
Copy link

Shouldn't it also have minimum window size?

@manishram manishram added the Paid label Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants