Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix with php 7.4 #96

Closed
Nelie-Taylor opened this issue Oct 7, 2019 · 5 comments
Closed

Please fix with php 7.4 #96

Nelie-Taylor opened this issue Oct 7, 2019 · 5 comments

Comments

@Nelie-Taylor
Copy link

  • Laravel Version: 6.0
  • PHP Version: 7.4
  • Database Driver & Version:

Description:

image

Steps to reproduce:

Thank you so much.

@gerpo
Copy link

gerpo commented Oct 8, 2019

Maybe you could submit a pull request? 7.4 is not yet officially released, but if you need it now you could help the community by helping to make the code ready for the release. That's the beauty of open source.

@lauhakari
Copy link

Fixed in #93 :)

@adelynx
Copy link

adelynx commented Dec 9, 2020

@Nelie-Taylor, this is the fix I have done and worked for me. I am using the package from my private repo as this one is not maintained anymore. I do suggest you to fork the repo to your account and use it from there after adding the fix. Good luck

foreach ($allLanguages as $languageKey) {
       $original[$languageKey] =
               isset($values[$languageKey])
                      ? $values[$languageKey]
                      : (isset($filesContent[$fileName][$languageKey][$key]) ? $filesContent[$fileName][$languageKey][$key] : '');
      }

@Lemmynjash
Copy link

@adelynx worked for me thanks alot

@abdialeh
Copy link

@adelynx worked for me too, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants