Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate hard runtime dependencies #3

Open
ajsharp opened this issue Feb 10, 2012 · 0 comments
Open

Eliminate hard runtime dependencies #3

ajsharp opened this issue Feb 10, 2012 · 0 comments

Comments

@ajsharp
Copy link

ajsharp commented Feb 10, 2012

From the gemspec:

  s.add_runtime_dependency 'sprockets',       '~> 2.0.0'
  s.add_runtime_dependency 'uglifier'
  s.add_runtime_dependency 'closure-compiler'
  s.add_runtime_dependency 'yui-compressor'
  s.add_runtime_dependency 'execjs'
  s.add_runtime_dependency 'therubyracer'

Sprockets itself doesn't force any of these dependencies on you, so I don't think sinatra-sprockets should either. We just want to use this to process and serve a few scss stylesheets, and don't want all the javascript runtime stuff, especially therubyracer which is a major pain to package in production.

So I'd advocate for the only runtime dependency here being sprockets itself, and if you want to use these other libraries, you need to include them in your Gemfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant