Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunked and encoded gzip not decompressing correctly in streams #96

Closed
theelous3 opened this issue Nov 2, 2018 · 2 comments · Fixed by #173
Closed

Chunked and encoded gzip not decompressing correctly in streams #96

theelous3 opened this issue Nov 2, 2018 · 2 comments · Fixed by #173

Comments

@theelous3
Copy link
Owner

theelous3 commented Nov 2, 2018

From #95 specifically #95 (comment)

The gzip module blows and isn't sophisticated enough to decompress streams. Drop it in favour of full zlib.

https://docs.python.org/3/library/zlib.html#zlib.decompress
https://stackoverflow.com/a/22311297

asl2 added a commit to asl2/asks that referenced this issue Feb 26, 2020
@gmacon
Copy link

gmacon commented Sep 15, 2020

I bumped into this today, and I found a work-around: I added ("Accept-Encoding", "identity") to the request headers to prevent the server from sending me compressed data.

I noticed that #157 has merge conflicts; I'd be happy to rebase it onto the latest master if other folks don't think they'll have time.

vcalvert pushed a commit to vcalvert/asks that referenced this issue Sep 18, 2020
@theelous3
Copy link
Owner Author

@gmacon Yes! I'm super swamped at a new position and haven't/won't have time for a while. Please feel free to repair the pr :)

gmacon pushed a commit to gmacon/asks that referenced this issue Sep 21, 2020
theelous3 added a commit that referenced this issue Sep 24, 2020
Fix decompression for chunked transfers (issue #96)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants