From 462e21ee57e94a18794ccdedc3602d91d2bf831f Mon Sep 17 00:00:00 2001 From: Kharhamel Date: Mon, 8 Jun 2020 14:35:43 +0200 Subject: [PATCH 1/3] regenerated the files --- generated/filesystem.php | 16 ++++++---------- generated/pcre.php | 4 +--- 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/generated/filesystem.php b/generated/filesystem.php index d82383ea..66e01e85 100644 --- a/generated/filesystem.php +++ b/generated/filesystem.php @@ -741,7 +741,7 @@ function flock($handle, int $operation, ?int &$wouldblock = null): void * break, you need to use the correct line-ending character(s) for your * operating system. Unix based systems use \n as the * line ending character, Windows based systems use \r\n - * as the line ending characters and Macintosh based systems use + * as the line ending characters and Macintosh based systems (Mac OS Classic) used * \r as the line ending character. * * If you use the wrong line ending characters when writing your files, you @@ -756,22 +756,18 @@ function flock($handle, int $operation, ?int &$wouldblock = null): void * 'b' or 't' as the last character * of the mode parameter. * - * The default translation mode depends on the SAPI and version of PHP that - * you are using, so you are encouraged to always specify the appropriate - * flag for portability reasons. You should use the 't' + * The default translation mode is 'b'. + * You can use the 't' * mode if you are working with plain-text files and you use * \n to delimit your line endings in your script, but - * expect your files to be readable with applications such as notepad. You + * expect your files to be readable with applications such as old versions of notepad. You * should use the 'b' in all other cases. * - * If you do not specify the 'b' flag when working with binary files, you + * If you specify the 't' flag when working with binary files, you * may experience strange problems with your data, including broken image * files and strange problems with \r\n characters. * - * For portability, it is strongly recommended that you always - * use the 'b' flag when opening files with fopen. - * - * Again, for portability, it is also strongly recommended that + * For portability, it is also strongly recommended that * you re-write code that uses or relies upon the 't' * mode so that it uses the correct line endings and * 'b' mode instead. diff --git a/generated/pcre.php b/generated/pcre.php index d61f9f8d..ceab9908 100644 --- a/generated/pcre.php +++ b/generated/pcre.php @@ -602,9 +602,7 @@ function preg_match(string $pattern, string $subject, array &$matches = null, in * @param string $subject The input string. * @param int|null $limit If specified, then only substrings up to limit * are returned with the rest of the string being placed in the last - * substring. A limit of -1 or 0 means "no limit" - * and, as is standard across PHP, you can use NULL to skip to the - * flags parameter. + * substring. A limit of -1 or 0 means "no limit". * @param int $flags flags can be any combination of the following * flags (combined with the | bitwise operator): * From eb3cda544efe79c214fbfc7ead502cf7494d206e Mon Sep 17 00:00:00 2001 From: Kharhamel Date: Mon, 8 Jun 2020 14:38:09 +0200 Subject: [PATCH 2/3] the ci now upload the code coverage to codecov --- .github/workflows/continuous-integration.yml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index 36f90628..9055e38a 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -109,10 +109,6 @@ jobs: name: "build" path: "generator/build" - - name: "Upload test coverage to coveralls" - continue-on-error: true - run: "php vendor/bin/php-coveralls -v" - working-directory: "generator" - env: - COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }} - COVERALLS_RUN_LOCALLY: 1 + - uses: codecov/codecov-action@v1 # upload the coverage to codecov + with: + fail_ci_if_error: true # optional (default = false) From 38114e3924b8c9871116ef742501f1c7bcb70a58 Mon Sep 17 00:00:00 2001 From: Kharhamel Date: Mon, 8 Jun 2020 14:55:18 +0200 Subject: [PATCH 3/3] fixed a type error in php 7.2 --- lib/DateTimeImmutable.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/DateTimeImmutable.php b/lib/DateTimeImmutable.php index 948b8f0f..878f65a8 100644 --- a/lib/DateTimeImmutable.php +++ b/lib/DateTimeImmutable.php @@ -226,7 +226,7 @@ public static function createFromMutable($dateTime): self * @param mixed[] $array * @return DateTimeImmutable */ - public static function __set_state(array $array): self + public static function __set_state($array): self { return self::createFromRegular(parent::__set_state($array)); }