-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate graphqlite-symfony-validator-bridge into graphqlite-bundle #78
Comments
It means that we won't allow using I'm OK with it because I don't know how many library consumers don't use Symfony as a framework. |
Ah, I hadn’t considered that use case. That might actually be the main reason it was separated initially. |
I don't really know what this lib does outside of Symfony framework. But #63 was added so that Symfony validator can hook into annotated Input types for validation. And it's very simple to setup. So, there shouldn't be any concerns about people being able to use the Symfony validator outside the framework. |
Right, I forgot about that. |
@Lappihuan I would do that. We have one class that handles all our Symfony validator logic for all our input types. It's very simple. I just don't know why this lib is needed, personally. But again, we don't use the framework. |
@andrew-demb Big thanks for unblocking the dependency hell this package and graphqlite-bundle were in!
To avoid similar issues in the future, we should reduce complexity and friction for updates.
I propose consolidating graphqlite-symfony-validator-bridge into the graphqlite-bundle. We can make symfony/validation a suggested dependency and throw an exception if validation attributes are used without it.
The text was updated successfully, but these errors were encountered: