From 7f1593f0ea42bd80c130a3a1051ac0a8ae366081 Mon Sep 17 00:00:00 2001
From: Barney Laurance <barney@thebiggive.org.uk>
Date: Thu, 2 Nov 2023 10:37:28 +0000
Subject: [PATCH 1/2] DON-877: Save my details dialog screen reader
 adjustments:

- Stop auto-focusing on the 'cancel' button so it doesn't have to be
  read first
- Set entire dialog content as 'aria-live' so it is automatically read
  out when the dialog is opened
- Change link copy from "Learn more" to "Learn more about stripe"
---
 .../donation-complete-set-password-dialog.html              | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/app/donation-complete/donation-complete-set-password-dialog.html b/src/app/donation-complete/donation-complete-set-password-dialog.html
index c92fc6484..5a3bbd69f 100644
--- a/src/app/donation-complete/donation-complete-set-password-dialog.html
+++ b/src/app/donation-complete/donation-complete-set-password-dialog.html
@@ -1,11 +1,11 @@
-<app-popup-standalone>
+<app-popup-standalone aria-live="polite">
   <h2 mat-dialog-title>Set a password</h2>
 
   <mat-dialog-content class="mat-typography">
     <form [formGroup]="form">
       <p>Email address: <strong>{{ data.person.email_address }}</strong></p>
 
-      <p><strong>Your last payment card</strong> will be saved for reuse. It is held securely only with Stripe. <a href="https://stripe.com/docs/security/stripe" target="_blank"><mat-icon class="b-va-bottom" aria-hidden="false" aria-label="Open in new tab">open_in_new</mat-icon> Learn more</a>.</p>
+      <p><strong>Your last payment card</strong> will be saved for reuse. It is held securely only with Stripe. <a href="https://stripe.com/docs/security/stripe" target="_blank"><mat-icon class="b-va-bottom" aria-hidden="false" aria-label="Open in new tab">open_in_new</mat-icon> Learn more about Stripe</a>.</p>
 
       <mat-form-field class="b-w-100" color="primary">
         <mat-label for="password">Password (at least {{ minPasswordLength }} characters)</mat-label>
@@ -21,6 +21,6 @@ <h2 mat-dialog-title>Set a password</h2>
 
   <mat-dialog-actions align="end">
     <button mat-raised-button id="createAccountButton" [disabled]="!form.valid" (click)="set()" color="primary">Create Account</button>
-    <button mat-raised-button [mat-dialog-close]="false" cdkFocusInitial color="accent">Cancel</button>
+    <button mat-raised-button [mat-dialog-close]="false" color="accent">Cancel</button>
   </mat-dialog-actions>
 </app-popup-standalone>

From 3af008b915b63d511cda2ce675fe9514c93a2818 Mon Sep 17 00:00:00 2001
From: Barney Laurance <barney@thebiggive.org.uk>
Date: Thu, 2 Nov 2023 10:43:45 +0000
Subject: [PATCH 2/2] DON-877: Make "You are now registered" copy aria-live

Screen readers should naw automatically read the text
"You are now registered. You can now donate faster using your chosen email address and password. "
when it appears, instead of waiting for the user to navigate to it.
---
 src/app/donation-complete/donation-complete.component.html | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/app/donation-complete/donation-complete.component.html b/src/app/donation-complete/donation-complete.component.html
index a2763709a..cf59954d4 100644
--- a/src/app/donation-complete/donation-complete.component.html
+++ b/src/app/donation-complete/donation-complete.component.html
@@ -50,10 +50,12 @@ <h2>Thank you!</h2>
           <p>This helps you to make doubling your donation easier.</p>
         </div>
 
+        <div aria-live="polite">
         <p *ngIf="registrationComplete" id="registrationCompleteText">
           <strong>You are now registered<span *ngIf="loggedIn"> and logged in</span>.</strong> You can now donate faster
           using your chosen email address and password.
         </p>
+        </div>
 
         <div class="cta" *ngIf="registrationComplete && loggedIn">
           <div class="button-wrapper">