Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Null Reference exception #119

Open
borrmann opened this issue Jun 5, 2024 · 7 comments
Open

[iOS] Null Reference exception #119

borrmann opened this issue Jun 5, 2024 · 7 comments

Comments

@borrmann
Copy link
Contributor

borrmann commented Jun 5, 2024

On iOS, occassionally I get the following error log:

The current view controller can not be detected. System.NullReferenceException void BottomSheetManager.PlatformShow(Window window, BottomSheet sheet,

I suspect it is due to line 25 in BottomSheetManager:

 BottomSheetController bottomSheetController2 = (sheet.Controller = new BottomSheetController(window.Handler.MauiContext, sheet));
@MarcAlx
Copy link

MarcAlx commented Jun 17, 2024

Hi, if you can find a reproductible failure case, I would be happy to complete my PR #122.

@softlion
Copy link

I get that crash constantly, after opening/closing the bottom sheet multiple times correctly, you need less than a dozen of open/close to make it crash.

image

@softlion
Copy link

I know there is an open issue on maui for that, with a fix from someone. But the maui team does not care and it looks like that won't be fixed in any version 8 release.

does your fix work well @MarcAlx, and did you publish a nuget ?
@the49ltd do you plan to update your nuget to incorporate that PR at some point in the near future ?

@MarcAlx
Copy link

MarcAlx commented Jun 20, 2024

@softlion I didn't publish a nuget package, check my PR it may help #122 I also comment in this issue : #94

In my project I include the project locally (without going through nuget) and fixes exception as they happen (thus my PR).

softlion added a commit to softlion/The49.Maui.BottomSheet that referenced this issue Jun 26, 2024
@softlion
Copy link

softlion commented Jul 1, 2024

@softlion I didn't publish a nuget package, check my PR it may help #122 I also comment in this issue : #94

In my project I include the project locally (without going through nuget) and fixes exception as they happen (thus my PR).

That did not fix it for me.
It stopped crashing, but it still thinks the popup is opened when it's not.

@GenCodeInc
Copy link

I get that crash constantly, after opening/closing the bottom sheet multiple times correctly, you need less than a dozen of open/close to make it crash.

image

same, is there an expected fix time to the nuget package?

@softlion
Copy link

softlion commented Nov 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants